Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headline/title to each update #375

Open
paulschreiber opened this issue Mar 20, 2018 · 5 comments · May be fixed by #474
Open

Add headline/title to each update #375

paulschreiber opened this issue Mar 20, 2018 · 5 comments · May be fixed by #474
Labels
Status: has patch Type: enhancement
Milestone
2.0

Comments

@paulschreiber
Copy link
Contributor

Allow live blog updates to have an optional headline/title.
@paulschreiber paulschreiber mentioned this issue Apr 4, 2018
Open
@cain
Copy link
Contributor

cain commented May 24, 2018

@paulschreiber
any specifications on the best way to do this? Inside the editor or a separate field? I love the way medium does it.

@cain cain mentioned this issue May 24, 2018
Open
@paulschreiber
Copy link
Contributor Author

We have this done. @adamsilverstein will be submitting a PR soon. You can see it in my fork.

@adamsilverstein
Copy link

@cain We implemented this as comment meta on the live updates. A new headline field is added above the editor and sent along with crud requests. You can see the changes for this feature (with only a few auxiliary changes) in this PR: https://github.com/paulschreiber/liveblog/pull/17/files and as Paul mentioned I'm working on a more complete PR with all of our recent updates.

@cain
Copy link
Contributor

cain commented May 25, 2018

@jvpcode

@cain
Copy link
Contributor

cain commented May 25, 2018

Awesome! I'll check this out 😻

@adamsilverstein adamsilverstein linked a pull request May 30, 2018 that will close this issue
Open
@philipjohn philipjohn added this to the 2.0 milestone Aug 20, 2018
@GaryJones GaryJones moved this to To do in Liveblog: 2.0 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: has patch Type: enhancement
Projects
Liveblog: 2.0
Status: To do
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Add Entry Headline and clear when creating new entry paulschreiber/liveblog
5 participants
@paulschreiber @GaryJones @philipjohn @adamsilverstein @cain