-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Koinonia: add theme #8470
Koinonia: add theme #8470
Conversation
Preview changesI've detected changes to the following themes in this PR: Koinonia. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
@henriqueiamarino Cute but without being cheesy. Nice work, mate.
To combat this, it's just a suggestion, but consider making the layout for the "Intro paragraph" "Services 1,2,3 and 4" default (i.e. not constrained). They don't change with a desktop view, but they all will stretch with a tablet view.
Let me know if I can clarify further on anything. |
Thanks, @iamtakashi. Here's what I changed on the latest commit:
|
@henriqueiamarino, thanks for the update. I pushed a commit to address these things.
I think the theme is now ready to launch. Ship it! 🚢 |
Theme-Check resultskoinonia: No changes required ✅. |
Thanks, @iamtakashi. Let me check the correct way to proceed with this before the merge. Last time, I pressed Squash and merge, expecting your changes to be added, but I think they were lost. Should I use one of the Update options before continuing? |
If no further change is pushed to this branch, you can squash and merge. I have already made changes to this branch, which will be deleted when you squash and merge. What might have happened last time was that you made the change on top of the local copy of the theme, which didn't pull my change correctly for some reason. |
Koinonia is a theme for non-profit organizations based on the theme Lativ. The category ‘non-profit’ was selected after a requirement in our list of priorities, while the topics
pets
andcommunity
created an interesting demo site.Demo site | Content export