Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini-cart shows unconverted amount when manually renewing subscription with Multi-Currency #6739

Closed
jessepearson opened this issue Jul 11, 2023 · 4 comments · Fixed by #10156
Assignees
Labels
category: core WC Payments core related issues, where it’s obvious. focus: multi-currency priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.

Comments

@jessepearson
Copy link
Contributor

Describe the bug

The mini-cart will initially show the unconverted amount for the product being renewed during the manual renewal process.

To Reproduce

Notes:

  • You may need to use WooCommerce Subscriptions directly, and you will need to have manual renewals enabled under WooCommerce > Settings > Subscriptions.
  • This was tested with the Storefront theme, which adds a mini-cart to the header of the site. If you are not using Storefront, you will need to add the mini-cart widget somewhere that it will show up on the checkout page.
  1. Create a simple subscription product.
  2. Add one additional currency under WooCommerce > Settings > Multi-Currency.
  3. Add the subscription product to your cart, and check out using a currency that is not the store default currency.
  4. On the order confirmation page, click into the subscription.
  5. Choose to Renew now.
  6. When the page loads, you will notice the mini-cart has the wrong amount.

Screenshots

Screenshot 2023-07-11 at 1 45 03 PM

Additional context

Found in the testing of:

@jessepearson jessepearson added type: bug The issue is a confirmed bug. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. component: customer multi-currency Issues related to customer multi-currency project category: core WC Payments core related issues, where it’s obvious. labels Jul 11, 2023
@jessepearson jessepearson self-assigned this Jul 12, 2023
@jessepearson
Copy link
Contributor Author

I was looking into this today while using the branch/PR that refactors a lot with Subscriptions compatibility (#7092) and found that it's still persistent there. What's odd is that it the value seems to be getting set during the call to get_cart_from_session in WooCommerce core, but I cannot determine why it's not converting at this moment.

There are factors we need to consider with this issue:

  • The merchant has to be using WCPay Multi-Currency.
  • The merchant has to be using WooSubscriptions, WCPay's version does not allow early renewals.
  • The merchant will have to have enabled Early Renewals in Subscriptions' settings.
  • The merchant has to be using Storefront or another theme that adds the mini-cart widget to the checkout page, or the merchant will have to have added the mini-cart widget to the checkout page.
  • A customer will need to have purchased a subscription in another currency, and then be renewing early.

Even with all of that, it's only a display issue that resolves itself on any sort of page reload. The actual purchase price is correct.

I am going to set this as unassigned to see if we receive any feed back from merchants and/or support about it.

@jessepearson jessepearson removed their assignment Sep 1, 2023
@dwainm dwainm removed the priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. label Oct 17, 2023
@pierorocca pierorocca added the priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability label Jan 18, 2024
@bborman22
Copy link
Contributor

@jessepearson
Copy link
Contributor Author

I got an email about the above comment and I wanted to make sure my last note was seen here. This issue has no merchant/support notes on it, so I don't think it's been experienced in the "wild", I just noticed it while being over thorough about things. It is likely a "wont-fix" type of issue due to it's only a display issue that requires a lot of boxes to be checked to even see it.

@pierorocca pierorocca removed the component: customer multi-currency Issues related to customer multi-currency project label Mar 13, 2024
@cesarcosta99 cesarcosta99 self-assigned this Jan 2, 2025
@cesarcosta99
Copy link
Contributor

@bborman22, FYI, I updated estimation to 3 here due to complexity and effort required.

@cesarcosta99 cesarcosta99 added this to the WooPayments 8.9.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: core WC Payments core related issues, where it’s obvious. focus: multi-currency priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants