Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune Kafka Configurer Module #15

Open
smcvb opened this issue Oct 15, 2019 · 3 comments
Open

Fine tune Kafka Configurer Module #15

smcvb opened this issue Oct 15, 2019 · 3 comments

Comments

@smcvb
Copy link
Member

smcvb commented Oct 15, 2019

At the moment, the only easy approach to configure the Kafka Extension in an Axon project, is to use the kafka-spring-boot-starter dependency provided.
It would be beneficial if the kafka module would contain a ConfigurerModule implementation, which for example could be tied in through the Service Loader mechanism, to configure Kafka outside of the scope of Spring (Boot) too.

@smcvb smcvb changed the title Kafka Configurer Module Introduce a Kafka Configurer Module Oct 15, 2019
@smcvb
Copy link
Member Author

smcvb commented Dec 6, 2019

A ModuleConfiguration implementation for Kafka Message Sources has been introduced in #17, more specifically PR #24.

@smcvb smcvb changed the title Introduce a Kafka Configurer Module Fine tune Kafka Configurer Module Dec 10, 2019
@smcvb smcvb self-assigned this Jul 28, 2021
@smcvb
Copy link
Member Author

smcvb commented Jul 28, 2021

This issue is paramount to move the Kafka Extension from Axon 4 to Axon 4.5, due to the graceful startup and shutdown process.
Being able to configure everything in one spot greatly simplifies that, hence why this issue's priority is increased.

@smcvb
Copy link
Member Author

smcvb commented Jul 28, 2021

After some further investigation, a more trivial solution was spotted to make this work.
Furthermore, since Kafka's Producer and Consumer require an abundance of properties, it's not straightforward to derive a concise ModuleConfiguration for the Kafka Module that doesn't use Spring.
This adjusts the priority and usefulness quite some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant