Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions on exception handling #49

Open
Sam-Kruglov opened this issue Apr 28, 2020 · 1 comment
Open

Suggestions on exception handling #49

Sam-Kruglov opened this issue Apr 28, 2020 · 1 comment

Comments

@Sam-Kruglov
Copy link

  1. On any exception caught, there should be a tag error=true set and some log entries like error.*, event, message, stack (see OpenTracing conventions). I also propose to have error.expected=true/false but it's minor.
  2. I think point-to-point queries don't have any error handling at all.
  3. I think eventHandler.getTargetType().getSimpleName() inside LoggingErrorHandler will include spring proxy like *EnhancerBySpring*.

See my error handlers in TracingAxonConfig. Logging. ErrorLoggingConfig

@smcvb
Copy link
Member

smcvb commented Apr 29, 2020

From the conventions, I note it's about logging the exceptions, not so much tagging. Regardless, it seems like a regular thing to do with Open Tracing, so thanks for the addition.

@smcvb smcvb added this to the Release 4.4 milestone Aug 11, 2020
@smcvb smcvb modified the milestones: Release 4.4, Release 4.5 Oct 30, 2020
@smcvb smcvb removed this from the Release 4.5 milestone Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants