refactor: use common DATA_DIRECTORY env var #10268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexghr
force-pushed
the
ag/data-dir-prover
branch
from
a691cd7
to
89a9b45
Compare
PhilWindle
reviewed
Nov 28, 2024
| proverBrokerDataDirectory: { | ||
| env: 'PROVER_BROKER_DATA_DIRECTORY', | ||
| description: 'If starting a prover broker locally, the directory to store broker data', | ||
| dataDirectory: { |
There was a problem hiding this comment.
Can ...dataConfigMappings be done instead?
There was a problem hiding this comment.
Not without adding a dependency on @aztec/kv-store to @aztec/circuit-types
There was a problem hiding this comment.
Hmm, it feels wrong then that circuit-types contains configuration types for apps. It seems much too low level for that.
PhilWindle
reviewed
Nov 28, 2024
| proverAgentCount: { | ||
| env: 'PROVER_AGENT_COUNT', | ||
| description: 'The number of prover agents to start', | ||
| ...numberConfigHelper(1), | ||
| }, | ||
| dataDirectory: { |
PhilWindle
reviewed
Nov 28, 2024
| /** Where to store temporary data */ | ||
| cacheDir?: string; | ||
|
|
||
| dataDirectory?: string; |
There was a problem hiding this comment.
Can you do export type ProverConfig = ActualProverConfig & { blah } & DataStoreConfig;?
There was a problem hiding this comment.
Same problem, we'd have to depend on kv-store in circuit-types
alexghr
force-pushed
the
ag/data-dir-prover
branch
from
89a9b45
to
b8766f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the custom env var to specify data directories for the prover and broker in favour of using the common config we already have
I have created a separate issue to cleanup the config for the broker/agent/prover/prover-client #10269