feat: agent and broker expose OTEL metrics #10264
Open
+330
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexghr
force-pushed
the
ag/proving-otel
branch
2 times, most recently
from
814cbf4
to
a4d28f0
Compare
alexghr
commented
Nov 28, 2024
Comment on lines
-277
to
-278
| const storeSizes = this.store.estimateSize(); | ||
| this.instrumentation.recordDBMetrics(storeSizes); |
There was a problem hiding this comment.
These stats are now automatically captured using observables.
PhilWindle
requested changes
Nov 28, 2024
| } | ||
| const metrics = this.getStats(); | ||
| observable.observe(this.dbMapSize, metrics.mappingSize); | ||
| observable.observe(this.dbNumItems, metrics.actualSize); |
There was a problem hiding this comment.
Oh this is a typo on my part. That should be metrics.numItems.
There was a problem hiding this comment.
Fixed! Totally missed it haha, nice catch
| ) { | ||
| this.dbMapSize = meter.createGauge(dbMapSizeDescriptor.name, { | ||
| this.dbMapSize = meter.createObservableGauge(dbMapSizeDescriptor.name, { |
There was a problem hiding this comment.
This observable approach is much better!
alexghr
force-pushed
the
ag/proving-otel
branch
from
a4d28f0
to
6b73bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instrumentation to both the proving broker and agent.