Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellspec unit tests can fail due to unpredictable dev environment #5322

Open
cameronmeissner opened this issue Nov 21, 2024 · 0 comments
Open

Comments

@cameronmeissner
Copy link
Collaborator

Shellspec unit tests currently use whatever shell happens to be installed on the developer's machine.

The problem with this is that the scripts shellspec is supposed to be testing are specifically meant to be run with a bash shell. This means that if a developer is using a different shell, such as zsh, shellspec tests will end up failing in any case where the scripts being tested utilize shell syntax that is not exportable from bash.

Solution would be to have shellspec tests run within a container where we can control exactly which shell is available within the environment.

@cameronmeissner cameronmeissner changed the title shelllspec unit tests can fail due to unpredictable dev environment shellspec unit tests can fail due to unpredictable dev environment Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant