Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Bug Report - Recovery Services Vault : "Migrate from classic alerts ..." false positive #470

Open
jdmsoss opened this issue Oct 17, 2024 · 1 comment · May be fixed by #539
Open

🪲 Bug Report - Recovery Services Vault : "Migrate from classic alerts ..." false positive #470

jdmsoss opened this issue Oct 17, 2024 · 1 comment · May be fixed by #539
Assignees
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Bug 🐞 Something isn't working

Comments

@jdmsoss
Copy link
Contributor

jdmsoss commented Oct 17, 2024

Describe the bug

Migrate from classic alerts to built-in Azure Monitor alerts for Azure Recovery Services Vaults ARG query produce false positives.

To Reproduce

Steps to reproduce the behaviour:

  1. Create a new Recovery Services Vault (without specific alerting configuration / strategy)
  2. Run the ARG query
  3. False positive!

Expected behaviour

This recommendation should only return Recovery Services Vault with classic alert configured. If classic alerts aren't configured, don't return the vault in the recommendation.

Additional context

The condition logic around monitoringSettings property (IF monitoringSettings isnull THEN classic alert is enabled) doesn't seem to be the best approach. Because when I configure Azure Alert and not Classic Alert for my vault, monitoringSettings still doesn't exist (so still a false positive).

@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Oct 17, 2024
@oZakari oZakari added the Area: Resource Graph Query(s) #️⃣ Related to ARG queries label Oct 22, 2024
@ejhenry ejhenry self-assigned this Nov 23, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Nov 23, 2024

Thanks for opening this bug @jdmsoss. We'll disable this recommendation query until we have a working version.

@ejhenry ejhenry linked a pull request Nov 27, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants