-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testability of source generators providing Verify into project #2691
Comments
I tried to make separated branch and put there a sample how it can look but I get:
so... |
@KondzioSSJ4 We welcome contributions to improve the product. Would you mind elaborating the problem you were trying/suggesting to solve? Apologies, I did not understand it totally. |
@kshyju For example...
And then run a test Also many diff files tools (like VS Code) shown syntax, so it's easier to check what's wrong with the output but main goal of this is allowing to make easier generators Benefits:
I know that there are some strange changes like:
|
re
did you fork the repository before trying to push the branch? |
what i dont understand about this issue and the patch is what you are trying to achieve? if you are proposing the azure-functions-dotnet-worker team use snapshot testing, i recommend starting with a smaller and simpler scenario. so you can explain the value of snapshot testing without the significant noise of a complex scenario if you want to use snapshot testing when building your azure functions, you should be able to do that without any changes in this repository if you have hit problems using snapshot testing to test your azure functions, then perhaps share a simple example of that problem |
Mostly... Easier way to make tests in project to validate source generated code via snapshot tests Also... side effect would be learn how I can contribute in this project
I already made in the patch file that I provided before
Nope, I would like to improve and make some source generators for AoT but current way of providing test is painfull and any change of existing source generator output required much more developer attention that it should be |
then i suggest you try much smaller and incremental changes that gradually improve this project. for example, i notice your change requires certain nugets to be updated. perhaps start with that as your first contribution |
@SimonCropp
(In method |
Description
Hi
I tried to make some improvements of the code by making a generator and providing a example how it can looks
but...
I have a problem with that tests because:
Can I provide a pull request with potential way of how improve tests and how we can verify the output?
Also... I'm not sure about license of the external library, if that is acceptable by your team or not
Link to that library: https://github.com/VerifyTests/Verify.SourceGenerators
The text was updated successfully, but these errors were encountered: