-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NeonPostgres PS cmdlets 2024-08-01-preview #26492
Conversation
️✔️Az.Accounts
|
Type | Cmdlet | Description | Remediation |
---|---|---|---|
Get-AzNeonPostgresOrganization | Get-AzNeonPostgresOrganization Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzNeonPostgresOrganization | Get-AzNeonPostgresOrganization changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.NeonPostgres. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
@almasak Hi, we have frozen the code for this release(2024-11-11). Your pr would be reviewed and merged in our next public release, which would be (2024-11-19) |
Sure, no problem. |
@almasak Please fill in the examples and test cases. The test coverage for a module should be no less than 80%. |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Added the examples |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 26492 in repo Azure/azure-powershell |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run license/cla |
No pipelines are associated with this pull request. |
@almasak Please write test cases for the new cmdlets and then record them |
Added! |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.