Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeonPostgres PS cmdlets 2024-08-01-preview #26492

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

almasak
Copy link
Member

@almasak almasak commented Oct 27, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Oct 27, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.NeonPostgres
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzNeonPostgresOrganization Get-AzNeonPostgresOrganization Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNeonPostgresOrganization Get-AzNeonPostgresOrganization changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.NeonPostgres. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@Nickcandy
Copy link
Contributor

@almasak Hi, we have frozen the code for this release(2024-11-11). Your pr would be reviewed and merged in our next public release, which would be (2024-11-19)

@almasak
Copy link
Member Author

almasak commented Oct 29, 2024

@almasak Hi, we have frozen the code for this release(2024-11-11). Your pr would be reviewed and merged in our next public release, which would be (2024-11-19)

Sure, no problem.

@vidai-msft
Copy link
Contributor

@almasak Please fill in the examples and test cases. The test coverage for a module should be no less than 80%.

@vidai-msft vidai-msft self-assigned this Nov 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@almasak
Copy link
Member Author

almasak commented Nov 6, 2024

@almasak Please fill in the examples and test cases. The test coverage for a module should be no less than 80%.

Added the examples

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@almasak
Copy link
Member Author

almasak commented Nov 8, 2024

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 26492 in repo Azure/azure-powershell

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run license/cla

Copy link
Contributor

No pipelines are associated with this pull request.

@vidai-msft
Copy link
Contributor

@almasak Please write test cases for the new cmdlets and then record them

@almasak
Copy link
Member Author

almasak commented Nov 8, 2024

@almasak Please write test cases for the new cmdlets and then record them

Added!

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft vidai-msft merged commit cb5aee8 into Azure:generation Nov 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants