ADE MSI powershell support #26652
Draft
ADE MSI powershell support #26652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2024 00:46
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
vimish
reviewed
Nov 30, 2024
| } | ||
| return false; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
The function should return true if encryption identity is already assigned. Can you validate this?
vimish
reviewed
Nov 30, 2024
| @@ -247,6 +257,29 @@ public override void ExecuteCmdlet() | |||
| } | |||
| } | |||
|
|
|||
| if (this.IsParameterBound(c => c.EncryptionIdentity)) | |||
There was a problem hiding this comment.
Will this return error if encryption identity is not part of identity getting assigned to the VM?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure Disk Encryption (ADE) is adding support for using managed identity to authenticate to customer's keyvault.
As part of it, a new field (EncryptionIdentity) has been added to the VM model. By setting this field customer will be notifying ADE to use that managed identity for keyvault operations. The identity should also be explicitly assigned to the VM.
This PR adds a new parameter (EncryptionIdentity) to Set-AzVMDiskEncryptionExtension cmdlet. If the parameter is present then the cmdlet will ensure that identity is assigned to the VM and the EncryptionIdentity field is updated.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.