Update PR Template for LTS Check #26756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
VeryEarly
reviewed
Nov 25, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -13,6 +13,8 @@ | |||
| - [ ] [Engineering build](../blob/main/CONTRIBUTING.md#target-release-types) | |||
| - [ ] No need for a release | |||
|
|
|||
| - [ ] **This needs to be added to LTS version!** | |||
There was a problem hiding this comment.
Suggested change
| - [ ] **This needs to be added to LTS version!** | |
| - [ ] **check this box if this pull request contains fixes for LTS version** |
There was a problem hiding this comment.
I think we should discuss more about how to notify PR authors in a better way.
Simply adding like this may not function as expected. Authors may not understand what is LTS and what should go into LTS version.
NoriZC
reviewed
Nov 25, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -13,6 +13,8 @@ | |||
| - [ ] [Engineering build](../blob/main/CONTRIBUTING.md#target-release-types) | |||
| - [ ] No need for a release | |||
|
|
|||
| - [ ] **Check this box if this pull request contains fixes for LTS version!** | |||
There was a problem hiding this comment.
Suggested change
| - [ ] **Check this box if this pull request contains fixes for LTS version!** | |
| - [ ] [LTS version](../blob/main/CONTRIBUTING.md#target-release-types). |
|
Agree with Nori. How about using bug fixes and security fixes to replace the term "LTS". We use this way to describe in our Learn docs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.