Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] not compatible with spring-boot 3.4.0 GA #43085

Closed
3 tasks done
davidkarlsen opened this issue Nov 25, 2024 · 4 comments
Closed
3 tasks done

[BUG] not compatible with spring-boot 3.4.0 GA #43085

davidkarlsen opened this issue Nov 25, 2024 · 4 comments
Assignees
Labels
azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone

Comments

@davidkarlsen
Copy link

davidkarlsen commented Nov 25, 2024

Describe the bug

The SDK is not compatible with latest spring-boot 3.4.0 GA release, as the deprecated class TaskExecutorBuilder has been removed from this release.

Exception or Stack Trace


	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:336)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:288)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:334)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1568)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1514)
	at org.springframework.beans.factory.support.ConstructorResolver.resolveAutowiredArgument(ConstructorResolver.java:913)
	at org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:791)
	... 59 more
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor]: Factory method 'credentialTaskExecutor' threw exception with message: org/springframework/boot/task/TaskExecutorBuilder
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.lambda$instantiate$0(SimpleInstantiationStrategy.java:199)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiateWithFactoryMethod(SimpleInstantiationStrategy.java:88)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:168)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:653)
	... 72 more
Caused by: java.lang.NoClassDefFoundError: org/springframework/boot/task/TaskExecutorBuilder
	at com.azure.spring.cloud.autoconfigure.implementation.context.AzureTokenCredentialAutoConfiguration.credentialTaskExecutor(AzureTokenCredentialAutoConfiguration.java:221)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.lambda$instantiate$0(SimpleInstantiationStrategy.java:171)
	... 75 more
Caused by: java.lang.ClassNotFoundException: org.springframework.boot.task.TaskExecutorBuilder
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 78 more

To Reproduce
Steps to reproduce the behavior:

Use this SDK on SB 3.4.0

Code Snippet
Add the code snippet that causes the issue.

Expected behavior
Should work with GA-releases (and proactive development and release happen to be ready at GA-release dates).

Screenshots
If applicable, add screenshots to help explain your problem.

Setup (please complete the following information):

  • OS: [e.g. iOS]
  • IDE: [e.g. IntelliJ]
  • Library/Libraries: [e.g. com.azure:azure-core:1.16.0 (groupId:artifactId:version)]
  • Java version: [e.g. 8]
  • App Server/Environment: [e.g. Tomcat, WildFly, Azure Function, Apache Spark, Databricks, IDE plugin or anything special]
  • Frameworks: [e.g. Spring Boot, Micronaut, Quarkus, etc]

If you suspect a dependency version mismatch (e.g. you see NoClassDefFoundError, NoSuchMethodError or similar), please check out Troubleshoot dependency version conflict article first. If it doesn't provide solution for the problem, please provide:

  • verbose dependency tree (mvn dependency:tree -Dverbose)
  • exception message, full stack trace, and any available logs

Additional context
Add any other context about the problem here.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@davidkarlsen davidkarlsen changed the title [BUG] [BUG] not compatible with spring-boot 3.4.0 GA Nov 25, 2024
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 25, 2024
@alzimmermsft alzimmermsft added azure-spring All azure-spring related issues and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 26, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Nov 26, 2024
@saragluna saragluna added this to the 2025-01 milestone Nov 29, 2024
@moarychan
Copy link
Member

This removal class TaskExecutorBuilder has been fixed in #42760

@gbrehmer
Copy link

gbrehmer commented Dec 4, 2024

Is an earlier release for the removed-class-fix planned? Because this could also be applied to the old code to remove usage of a deprecated class. then some of the functionality would be already compatible with Spring boot 3.4.0 with full backwards compatibility

@saragluna
Copy link
Member

Spring Cloud Azure 5.19.0 has been released.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Spring Cloud Azure Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Status: Done
Development

No branches or pull requests

5 participants