Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Java SDK for compute TypeSpec migration #43116

Open
Tracked by #1850
live1206 opened this issue Nov 27, 2024 · 5 comments
Open
Tracked by #1850

Compare Java SDK for compute TypeSpec migration #43116

live1206 opened this issue Nov 27, 2024 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Compute Mgmt - Track 2 needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team

Comments

@live1206
Copy link
Member

We are working on the compute TypeSpec migration.
Would like Java to verify the SDK generation of the corresponding swagger of the converted TypeSpec.
We have split compute into multiple sub services and done the conversion for each of them.

For instance, Compute sub-service:

Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @amjads1 @avirishuv @Drewm3 @Vaibhav-Agar.

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Compute needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. labels Nov 27, 2024
@XiaofeiCao XiaofeiCao self-assigned this Nov 27, 2024
@XiaofeiCao XiaofeiCao removed the Service Attention Workflow: This issue is responsible by Azure service team. label Nov 29, 2024
@XiaofeiCao
Copy link
Contributor

XiaofeiCao commented Nov 29, 2024

Current major issue is that some of the LIST operations are not generated with pageable, e.g.
https://github.com/XiaofeiCao/azure-rest-api-specs/blob/typespec_compute/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-07-01/ComputeRP.json#L1582

Original swagger: https://github.com/XiaofeiCao/azure-rest-api-specs/blob/typespec_compute/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-07-01/computeRPCommon.json#L171-L173

Majority of the compilation issues are caused by this.

@pshao25
Copy link
Member

pshao25 commented Dec 2, 2024

@XiaofeiCao
Copy link
Contributor

Compilation issues

1. LIST without pageable

2. VirtualMachineScaleSetExtension without settable name property

Though there's PUT operation for VirtualMachineScaleSetExtension, we can still create one within VitualMachineScaleSet. Thus name property should be included as well.
(name property in common model ProxyResource is read-only and not settable)
current swagger: https://github.com/XiaofeiCao/azure-rest-api-specs/blob/a5f4c22d62eecd7f15f2434d0fca00dc3589b01d/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-07-01/ComputeRP.json#L19009-L19027
original swagger: https://github.com/XiaofeiCao/azure-rest-api-specs/blob/typespec_compute/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-07-01/virtualMachineScaleSet.json#L4479-L4481
(Current Java codegen still has issue even if it's added, could be azure-json issue. Though name should be there anyway.)

3. No AvailabilitySetSkuType model

This seems an orphan model, though Java still uses it in handwritten code. Not sure if other languages use it.
https://github.com/XiaofeiCao/azure-rest-api-specs/blob/typespec_compute/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-07-01/availabilitySet.json#L490

@XiaofeiCao
Copy link
Contributor

XiaofeiCao commented Dec 2, 2024

@pshao25 I've compiled a complete list of current swagger issues that generate compilation errors for Java.

I've yet to run tests and generate apiviews. Will update above list once those are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Compute Mgmt - Track 2 needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Development

No branches or pull requests

3 participants