Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAI] Introduce a new option class for the streaming methods, getCompletionsStream and getChatCompletionsStream #43119

Open
mssfang opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. OpenAI

Comments

@mssfang
Copy link
Member

mssfang commented Nov 27, 2024

Rethink and redesign the CompletionsOption and ChatCompletionsOption classes.

Since we have separate method for both of streaming and non-streaming completions and chat completions methods, we should separate the optional classes into ChatCompletionsOption and a new ChatCompletiondsStreamOption, as well as CompletionsOption and a new CompletionsStreamOption.

For example,

  • ChatCompletionsStreamOption should have stream=true by default and include all parameters related only to streaming.
  • ChatCompletionsOption should not include parameters related only to streaming.
@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. OpenAI labels Nov 27, 2024
@mssfang mssfang self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenAI
Projects
None yet
Development

No branches or pull requests

1 participant