-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixChangeFeedHangWhenUsingStaleContainerRid #43729
Draft
tvaron3
wants to merge
11
commits into
Azure:main
Choose a base branch
from
tvaron3:tvaron3/annie/fixForChangeFeedQueryWhenContainerReCreated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fixChangeFeedHangWhenUsingStaleContainerRid #43729
tvaron3
wants to merge
11
commits into
Azure:main
from
tvaron3:tvaron3/annie/fixForChangeFeedQueryWhenContainerReCreated
+573
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check API changes are not detected in this pull request. |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
…to tvaron3/annie/fixForChangeFeedQueryWhenContainerReCreated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up this pr #43114
Issue:
When query changeFeed with an invalid continuation token (container got recreated in this case, which means the continuationToken uses stale containerRid), SDK will return incorrect result or hang.
Root Cause:
For container re-created with same RU or same feedRanges -> SDK will reuse the token(lsn) to resume the read from the new container, which could cause missing data
For container re-created with different RU or different feed Ranges, the feedRange in the continuationToken spans multiple partitions of the new container -> SDK will be in a hang status (due to endless retries).
Fixes:
x-ms-cosmos-intended-collection-rid
for changeFeed request, eventually 400/1024 will be bubbled up to customerScenarios Tested for Backwards Compatibility