Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] ACR: Optimize auth flow #34642

Open
lmolkova opened this issue Mar 1, 2023 · 0 comments
Open

[FEATURE REQ] ACR: Optimize auth flow #34642

lmolkova opened this issue Mar 1, 2023 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Milestone

Comments

@lmolkova
Copy link
Member

lmolkova commented Mar 1, 2023

Library name

Azure.Containers.ContainerRegistry

Please describe the feature.

ACR uses oauth2 and gets refresh token and access token.
A refresh token is obtained with AAD token and cached in memory. It's the same for the repository.

We get access token on each request using a refresh token. The access token is scoped to specific actions and repository. It's valid (currently) for about an hour.

It's safe and doable to cache access token (either per action + client instance or bluntly once) and only refresh it on 401.

this is not blocking GA.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 1, 2023
@lmolkova lmolkova added Container Registry Client This issue points to a problem in the data-plane of the library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 1, 2023
@annelo-msft annelo-msft added this to the 2023-04 milestone Mar 1, 2023
@annelo-msft annelo-msft modified the milestones: 2023-04, Backlog Mar 22, 2023
@pallavit pallavit modified the milestones: Backlog, 2023-06 Apr 24, 2023
@annelo-msft annelo-msft modified the milestones: 2023-06, Backlog May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
Status: No status
Development

No branches or pull requests

3 participants