Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and improve the certificates model validation into the shared KV test project #35286

Open
3 tasks
heaths opened this issue Mar 31, 2023 · 0 comments
Open
3 tasks
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-enhancement
Milestone

Comments

@heaths
Copy link
Member

heaths commented Mar 31, 2023

Based on the code for #35254 to validate some of the read-write models, move the code into the shared test project and make some improvements to be more generic and support more types e.g.,

  • Rename method to be more obvious e.g., PopulateAndAssertModel<T> c/o @christothes
  • Support DateTimeOffsets e.g., use the property name hash code as input to DateTimeOffset.FromUnixTimeSeconds
  • Can make code to set a Nullable<T> more generic so those don't all have to be implemented explicitly

This will be specific to Key Vault where models may implement a couple of internal interfaces for serialization but may work for what @m-nash has been thinking about for generic DPG serialization.

@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. test-enhancement labels Mar 31, 2023
@heaths heaths added this to the 2023-05 milestone Mar 31, 2023
@heaths heaths self-assigned this Mar 31, 2023
@heaths heaths modified the milestones: 2023-05, 2023-06 May 11, 2023
@pallavit pallavit modified the milestones: 2023-06, Backlog Jun 28, 2023
@chlowell chlowell assigned JonathanCrd and unassigned heaths Aug 1, 2024
@chlowell chlowell moved this from Untriaged to Not Started in Azure SDK for Key Vault Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-enhancement
Projects
Status: Not Started
Development

No branches or pull requests

3 participants