Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] Support resumable upload when ACR service supports it #35322

Open
annelo-msft opened this issue Apr 3, 2023 · 0 comments
Open

[ACR] Support resumable upload when ACR service supports it #35322

annelo-msft opened this issue Apr 3, 2023 · 0 comments
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Milestone

Comments

@annelo-msft
Copy link
Member

Container Registry blob upload could fail with status code 404 and an error like {"errors":[{"code":"BLOB_UPLOAD_INVALID","message":"blob upload invalid"}]}. It happens when a transient issue (like connection reset) occurs and chunk upload is retried, but can happen for other reasons as well.

If this happens, it's not possible to resume upload - it has to be started all over.

This issue tracks the work to implement resumable upload once the service supports it. We could do this as follows: when a retry fails, get the size of the uploaded blob and resume uploading chunks from that range.

Also, the ACR TSG currently gives guidance to the caller to resume the upload manually in the case of this failure. We will want to remove this guidance if we fully fix the issue in the client.

@annelo-msft annelo-msft added the Client This issue points to a problem in the data-plane of the library. label Apr 3, 2023
@annelo-msft annelo-msft added this to the Backlog milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
Status: No status
Development

No branches or pull requests

1 participant