Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving NetworkTimeout to HttpPipelineTransportOptions #37736

Open
JoshLove-msft opened this issue Jul 19, 2023 · 1 comment
Open

Consider moving NetworkTimeout to HttpPipelineTransportOptions #37736

JoshLove-msft opened this issue Jul 19, 2023 · 1 comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@JoshLove-msft
Copy link
Member

          > Again to ground my understanding - if a caller sets a RetryPolicy, does that mean we completely ignore RetryOptions? (It sounds like what you're saying above, but I want to confirm I'm understanding correctly.)

Nope, we still will thread the NetworkTimeout through to the ResponseBodyPolicy. I agree that the story is a bit confusing with how we are presenting RetryPolicy as an override to RetryOptions. I would suggest we consider moving NetworkTimeout somewhere that is more sensible (perhaps TransportOptions) as @christothes suggests.

Originally posted by @JoshLove-msft in #37715 (comment)

@JoshLove-msft JoshLove-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Jul 19, 2023
@github-actions github-actions bot added the needs-team-triage Workflow: This issue needs the team to triage. label Jul 19, 2023
@JoshLove-msft
Copy link
Member Author

Consider applying EBN to the one on RetryOptions and putting new property on HttpPipelineTransportOptions which would take precedence over the RetryOptions one.

@jsquire jsquire removed the needs-team-triage Workflow: This issue needs the team to triage. label Jul 20, 2023
@annelo-msft annelo-msft added this to the Backlog milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

3 participants