Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Library-specific ResponseClassifier is overriden by protocol methods #37767

Open
JoshLove-msft opened this issue Jul 21, 2023 · 0 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@JoshLove-msft
Copy link
Member

JoshLove-msft commented Jul 21, 2023

For any libraries that define both a custom ResponseClassifier via HttpPipelineBuilder (e.g. like in Storage) and generate protocol methods (e.g. like in Tables), the library-specific ResponseClassifier would be replaced by the generated method-specific classifier.

Today, the only libraries that customize ResponseClassifier are Identity and Storage - neither of which generate protocol methods, so I don't believe any libraries are currently impacted by this.

While it does make sense that the method classifier would take precedence over the library classifier, it would be better if the library-specific classifier was put at the end of the chain using a ChainingClassifier so that the library-specific classifier code can still run for the non-specified status codes.

@JoshLove-msft JoshLove-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Jul 21, 2023
@annelo-msft annelo-msft added this to the Backlog milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

2 participants