Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Azure.Core approaches for handling generation of client-request-id headers #38799

Open
6 tasks
christothes opened this issue Sep 18, 2023 · 1 comment
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@christothes
Copy link
Member

Related to #37427

Given the proposal to have generated REST request creation methods add the client request id header (with the actual header name defined by the API spec), investigate the implications of this in the following scenarios:

  • The ClientRequestIdPolicy continues to exist and add the standard client-request-id header

    • Generated code adds a non-standard request id header that does not conflict with the standard header name
    • Generated code adds a non-standard request id header that does conflict with the standard header name
  • The ClientRequestIdPolicy goes away and all request id headers are generated

    • Verify CreateClientRequestIdScope still works
    • Determine if there are any other issues
@christothes christothes self-assigned this Sep 18, 2023
@christothes christothes added this to the Backlog milestone Sep 18, 2023
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels Sep 18, 2023
@jsquire jsquire removed the needs-team-triage Workflow: This issue needs the team to triage. label Sep 19, 2023
@christothes
Copy link
Member Author

christothes commented Sep 21, 2023

Discussed in stand-up today that, ideally, we would get away from the CreateClientRequestIdScope functionality in favor of a RequstContent option to control this for protocol method clients. The existing policy and CreateClientRequestIdScope would remain for current/legacy clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

2 participants