Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure.Core 2.0: Reimplement NoValueResponse<T>so it doesn't duplicate the response field #40557

Open
annelo-msft opened this issue Dec 4, 2023 · 0 comments
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Milestone

Comments

@annelo-msft
Copy link
Member

The shared source file NoValueResponse should not add a new field _response when it can get it from the base OutputMessage type in ClientModel. Today, because it is internal shared source used across many libraries, it is too complicated to implement this.

We should come back and reimplement it to get the performance gain when time allows as part of the Azure.Core 2.0 work.

It could look like this: https://github.com/Azure/azure-sdk-for-net/blob/a4c872765cf791b564ca5d1abb27b96844d7ff25/sdk/core/Azure.Core/src/Shared/NoValueResponseOfT.cs

@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core System.ClientModel Base Core library labels Dec 4, 2023
@annelo-msft annelo-msft assigned m-nash and unassigned m-nash Dec 4, 2023
@annelo-msft annelo-msft added this to the 2024-03 milestone Dec 4, 2023
@annelo-msft annelo-msft self-assigned this Dec 13, 2023
@annelo-msft annelo-msft modified the milestones: 2024-03, 2024-04 Feb 1, 2024
@annelo-msft annelo-msft modified the milestones: 2024-04, Backlog Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Projects
None yet
Development

No branches or pull requests

3 participants