Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientModel: Evaluate consistency across transports with regard to casing of request.Method #40616

Open
8 of 12 tasks
annelo-msft opened this issue Dec 6, 2023 · 0 comments
Open
8 of 12 tasks
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Milestone

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Dec 6, 2023

System.ClientModel APIView

  • PipelineProcessor/IEnumerable - ClientModel: Rework PipelineProcessor #40691
  • KeyCredential/Policy - ClientModel: KeyCredentialAuthenticationPolicy API updates #40705
  • RequestOptions.Apply investigation and rework - ClientModel: Remove RequestOptions.Apply #40706
  • Evaluate whether there is consistency across transports with regard to handling casing of request.Method
  • Evaluate whether having both AddHeader and SetHeader methods on RequestOptions overly complicates the public APIs - if it does not, add SetHeader and track the work needed for generated CreateRequest routines to support it.
  • Evaluate how hard it is to remove IEnumerable from MessageHeaders
  • Can we make ResponseStatusClassifier internal? - ClientModel: Make ResponseStatusClassifier internal #40709
  • Make Azure.Core ClientOptions inherit from ClientModel PipelineOptions
  • Decide whether RequestOptions and BinaryContent should move into .Primitives namespace given their use in protocol methods and not convenience methods
    • Investigation: Understand whether Storage convenience methods would reasonably use these types
  • Update KeyCredentialAuthenticationPolicy per:
    • KrzysztofCwalina 1 hour ago
      header name should be optional. The default value should be "Authorization"
    • KrzysztofCwalina [1 hour ago]
      I would also love to have a ctor for the most common scenario. We should also consider this ctor to take string in addition to KeyCredentail. For context, this is to enable RestClient scenarios.
  • Update PipelinePolicy per:
    • KrzysztofCwalina 1 hour ago
      I would like policies to have the following property:
      public PipelinePosition DefaultPosition { get; }
      In addition, all APIs that take a policy and the position (e.g. Add(PipelInePolisy, PipelinePosition) should default the second parameter. This would allow adding policies without having to specify the position (which users often don't know what it should be),This is to support RestClient scenarios.
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core CoreGe System.ClientModel Base Core library labels Dec 6, 2023
@annelo-msft annelo-msft self-assigned this Dec 6, 2023
@annelo-msft annelo-msft added this to the 2023-12 milestone Dec 7, 2023
@jsquire jsquire modified the milestones: 2023-12, 2024-02 Dec 12, 2023
@annelo-msft annelo-msft modified the milestones: 2024-02, 2024-01 Dec 12, 2023
@annelo-msft annelo-msft modified the milestones: 2024-01, 2024-02 Jan 3, 2024
@annelo-msft annelo-msft changed the title ClientModel: Resolve comments from ClientModel APIView ClientModel: Evaluate consistency across transports with regard to casing of request.Method Feb 1, 2024
@annelo-msft annelo-msft modified the milestones: 2024-02, 2024-03 Feb 2, 2024
@annelo-msft annelo-msft modified the milestones: 2024-03, Backlog Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Projects
None yet
Development

No branches or pull requests

2 participants