Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientModel: Give PipelinePolicies a DefaultPosition #41392

Open
annelo-msft opened this issue Jan 18, 2024 · 1 comment
Open

ClientModel: Give PipelinePolicies a DefaultPosition #41392

annelo-msft opened this issue Jan 18, 2024 · 1 comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Milestone

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Jan 18, 2024

Feature request

KrzysztofCwalina 5 weeks ago
I would like policies to have the following property:

public PipelinePosition DefaultPosition { get; }

In addition, all APIs that take a policy and the position (e.g. Add(PipelInePolisy, PipelinePosition) should default the second parameter. This would allow adding policies without having to specify the position (which users often don't know what it should be),

This is to support RestClient scenarios.

In addition, this change should address

Comments in PR thread: #41325 (comment)

@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core CoreGe System.ClientModel Base Core library labels Jan 18, 2024
@annelo-msft annelo-msft added this to the 2024-02 milestone Jan 18, 2024
@annelo-msft annelo-msft self-assigned this Jan 18, 2024
@annelo-msft
Copy link
Member Author

Per conversation with @KrzysztofCwalina, this would be additive, so moving to a later milestone.

@annelo-msft annelo-msft modified the milestones: 2024-02, 2024-03 Jan 23, 2024
@annelo-msft annelo-msft modified the milestones: 2024-03, 2024-04 Feb 1, 2024
@annelo-msft annelo-msft removed their assignment Mar 12, 2024
@annelo-msft annelo-msft modified the milestones: 2024-04, Backlog Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Projects
None yet
Development

No branches or pull requests

2 participants