Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientModel: Add unit tests to validate policy ordering in default pipeline construction logic for Azure.Core and ClientModel pipelines #41467

Open
annelo-msft opened this issue Jan 22, 2024 · 1 comment
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Milestone

Comments

@annelo-msft
Copy link
Member

Evaluate whether Azure.Core HttpPipeline can use the same logic as ClientPipeline for creating the default pipeline – to ensure default pipelines have same policy orderings. Should HttpPipeline inherit from ClientPipeline?

@tg-msft FYI

@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core CoreGe System.ClientModel Base Core library labels Jan 22, 2024
@annelo-msft annelo-msft added this to the 2024-02 milestone Jan 22, 2024
@annelo-msft annelo-msft self-assigned this Jan 22, 2024
@annelo-msft
Copy link
Member Author

@KrzysztofCwalina has investigated this, and reported it is complicated and viral - because Policy types are different and don't inherit. We will solve this problem by adding unit tests to validate that the default pipelines are in sync.

@annelo-msft annelo-msft changed the title ClientModel: Investigate reusability of default pipeline construction logic ClientModel: Add unit tests to validate policy ordering in default pipeline construction logic for Azure.Core and ClientModel pipelines Jan 31, 2024
@annelo-msft annelo-msft modified the milestones: 2024-02, 2024-03 Feb 2, 2024
@annelo-msft annelo-msft modified the milestones: 2024-03, 2024-04 Feb 14, 2024
@annelo-msft annelo-msft modified the milestones: 2024-04, Backlog Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Projects
None yet
Development

No branches or pull requests

2 participants