Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientModel: Address APIView feedback regarding Freeze APIs #41664

Open
annelo-msft opened this issue Jan 30, 2024 · 1 comment
Open

ClientModel: Address APIView feedback regarding Freeze APIs #41664

annelo-msft opened this issue Jan 30, 2024 · 1 comment
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Milestone

Comments

@annelo-msft
Copy link
Member

Address @tg-msft's questions:

  • What's the reason for the new Freeze methods on PipelineOptions and RequestOptions?
  • How do we expect people to use it?
  • What happens when I modify a frozen value?
  • How deep does freezing go (i.e., do the allow lists in DiagnosticOptions become immutable too)?
  • How does it impact the story for ClientOptions.Default?

Notes from @tg-msft:

https://github.com/Azure/azure-sdk-pr/issues/693 has the details for why ClientOptions.Default was added (tl;dr so Chaos could add PerTransport policies globally and without instrumenting/reshipping all our libraries).

@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core CoreGe 🐶 System.ClientModel Base Core library labels Jan 30, 2024
@annelo-msft annelo-msft added this to the 2024-02 milestone Jan 30, 2024
@annelo-msft annelo-msft self-assigned this Jan 30, 2024
@annelo-msft annelo-msft modified the milestones: 2024-02, 2024-03 Feb 2, 2024
@annelo-msft
Copy link
Member Author

I think we will not end up adding the Freeze API to ClientOptions or have it inherit from ClientPipelineOptions. Moving this to the backlog for now to preserve the questions in case we pick up this piece in the Azure.Core 2.0 integration work.

@annelo-msft annelo-msft modified the milestones: 2024-03, Backlog Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Projects
None yet
Development

No branches or pull requests

2 participants