Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Core: Optimize RequestContent.Create from IPersistableModel<T> #42259

Open
annelo-msft opened this issue Feb 28, 2024 · 0 comments
Open

Azure.Core: Optimize RequestContent.Create from IPersistableModel<T> #42259

annelo-msft opened this issue Feb 28, 2024 · 0 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Milestone
Backlog

Comments

@annelo-msft
Copy link
Member

In the comment #42226 (comment), @KrzysztofCwalina noticed that we could improve the performance of RequestContent.Create from an IPersistableModel by not using an adapter.

Suggestions included exposing low-level APIs on ModelReaderWriter in System.ClientModel and/or just not lazily writing the content stream for models and calling the APIs on ModelReaderWriter directly from the Create method.

This issue tracks the work to improve the performance of this operation based on this observation.
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core System.ClientModel Base Core library labels Feb 28, 2024
@annelo-msft annelo-msft added this to the 2024-04 milestone Feb 28, 2024
@annelo-msft annelo-msft mentioned this issue Feb 28, 2024
Merged
@annelo-msft annelo-msft modified the milestones: 2024-04, Backlog Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@annelo-msft