Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUERY]: Is OpenTelemetry Baggage supported #44348

Closed
MarcusKohnert opened this issue May 31, 2024 · 5 comments
Closed

[QUERY]: Is OpenTelemetry Baggage supported #44348

MarcusKohnert opened this issue May 31, 2024 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus

Comments

@MarcusKohnert
Copy link

MarcusKohnert commented May 31, 2024

Library name and version

Azure.Messaging.ServiceBus 7.17.5

Query/Question

@lmolkova wrote here that OpenTelemetry Baggage will be gradually adopted once it is approved.

I couldn't find any information if that adoption took place already.
Here it sounds like it should work.

I couldn't get Baggage propagation over process boundaries working in my local development setup.

This is my scenario:

Process A, populates Baggage items via Activity.Current?.SetBaggage("", "")
Process A, sends message to Azure Service Bus
Process B, receives message from Azure Service Bus

Expected result:

Process B, Activity.Current has Baggage items

Actual result:

Process B, Activity.Current has no baggage

Is Baggage propagation already supposed to work?
If yes, do I need to turn on specific things (Flags or similar)?
Is maybe the transport mechanism to ServiceBus relevant?

Thanks for any hints or pointers?

Environment

dotnet --info
.NET SDK:
Version: 8.0.204
Commit: c338c7548c
Workload version: 8.0.200-manifests.7d36c14f
Runtime:
OS Name: Windows
OS Version: 10.0.19045
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\8.0.204\

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus labels May 31, 2024
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@jsquire jsquire assigned lmolkova and unassigned JoshLove-msft May 31, 2024
@jsquire
Copy link
Member

jsquire commented May 31, 2024

@lmolkova : Would you mind offering your insight?

@lmolkova
Copy link
Member

lmolkova commented Jun 1, 2024

Thanks @MarcusKohnert !

The short answer is no, unfortunately Baggage is not supported - Azure/azure-sdk#6959
The long answer - we don't have a good way to support it in OTel-compatible way - open-telemetry/opentelemetry-dotnet#5667:

TL;DR: OTel does not recommend using Activity.Baggage and does not support propagating it. It has a separate baggage implementation outside of .NET BCL.
The propagation used by .NET is DistributedContextPropagator - its default implementation uses a different header name (Correlation-Context) than OTel (https://w3c.github.io/baggage/).

If we did use DistributedContextPropagator in .NET libraries, our .NET messaging would become incompatible with our instrumentation in other languages in the default case.

So the only viable path forward I see is to fix the problem on the OTel side before we can support baggage properly.

@jsquire jsquire added issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Jun 1, 2024
Copy link

github-actions bot commented Jun 1, 2024

Hi @MarcusKohnert. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

@MarcusKohnert
Copy link
Author

@lmolkova Thank you very much for the explanation.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus
Projects
None yet
Development

No branches or pull requests

4 participants