Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive mode results in an empty refresh_token #499

Open
kaplik opened this issue Jul 30, 2024 · 3 comments
Open

interactive mode results in an empty refresh_token #499

kaplik opened this issue Jul 30, 2024 · 3 comments

Comments

@kaplik
Copy link

kaplik commented Jul 30, 2024

As described here in #311 it looks like interactive login mode is not getting a refresh token, so reauth is required every ~70 minutes (validity of AAD access token). It looks like all the upstream issues mentioned in the original issue #311 in azure go sdk are closed/implemented.

Using interactive is IMO more user-friendly and should support caching of the refresh token in a similar way to how devicecode works.

@weinong
Copy link
Contributor

weinong commented Aug 31, 2024

@jan-di
Copy link

jan-di commented Oct 9, 2024

I think azidentity sdk 1.8.0 was released yesterday:
https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fazidentity%2Fv1.8.0

And there is already a dependabot pull request :-)
#534

@weinong
Copy link
Contributor

weinong commented Oct 23, 2024

cool. I will take a look next week. I actually re-wrote almost everything in https://github.com/weinong/kubelogin/tree/feat/token-cache with preview sdk. If you want to test, go for it! I need to add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants