Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to configure networkWatcher RG tags #420

Open
wetwicky opened this issue Sep 26, 2024 · 0 comments
Open

feat: allow to configure networkWatcher RG tags #420

wetwicky opened this issue Sep 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@wetwicky
Copy link

wetwicky commented Sep 26, 2024

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Is your feature request related to an issue?

Cannot use the module resourcegroup_networkwatcherrg as it doesn't allow to customize the tags which for some organization using azure policies to inherit tag from subscription cause terraform to detect drift every time terraform is triggered.

# Resource groups module for network watcher
module "resourcegroup_networkwatcherrg" {
  source              = "./modules/resourcegroup"
  count               = var.network_watcher_resource_group_enabled ? 1 : 0
  subscription_id     = local.subscription_id
  location            = var.location
  resource_group_name = "NetworkWatcherRG"
  tags                = {}
}.

adding an optional input variable to configure the tag would alllow to use it

Describe the solution you'd like

add an input variable to be able to setup tags on NetworkWatcherRG resource group.

# Resource groups module for network watcher
module "resourcegroup_networkwatcherrg" {
  source              = "./modules/resourcegroup"
  count               = var.network_watcher_resource_group_enabled ? 1 : 0
  subscription_id     = local.subscription_id
  location            = var.location
  resource_group_name = "NetworkWatcherRG"
  tags                = var.network_watcher_resource_group_enabled 
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants