Fix linux build failure affecting tcl/tk, make jobserver related.

Build was failing during Tcl install phase, which was a plain
"make install" and resulting in an error:

make[3]: *** read jobs pipe: Bad file descriptor.  Stop.
make[3]: *** Waiting for unfinished jobs....

This error is related to the make jobserver feature, pointing at
a likely cmake bug in the generated make logic, or a bug in make
itself, or an OS named pipe bug.  Bug encountered on VMs as well
as OpenSuse Linux (which may or may not have been a VM).

Unexpected workaround was to actually add the -j flag to the make
calls which disables jobserver mode on recursive make invocations.
Took that opportunity to enforce -j1 on install calls to avoid
any possibility of output race ordering on what should be an
I/O-bound build stage.

Author: brlcad

flexbison/CMakeLists.txt

@@ -58,7 +58,7 @@ if (NOT WIN32)
       CONFIGURE_COMMAND ${FLEX_SRC_DIR}/autogen.sh
       COMMAND ${FLEX_SRC_DIR}/configure --prefix=${CMAKE_NOBUNDLE_INSTALL_PREFIX}
       BUILD_COMMAND make -j${pcnt}
-      INSTALL_COMMAND make install
+      INSTALL_COMMAND make -j1 install
       DEPENDS ${ZLIB_TARGET}
       LOG_CONFIGURE ${EXT_BUILD_QUIET}
       LOG_BUILD ${EXT_BUILD_QUIET}
@@ -88,7 +88,7 @@ if (NOT WIN32)
       COMMAND ${BISON_SRC_DIR}/autogen.sh
       COMMAND ${BISON_SRC_DIR}/configure --prefix=${CMAKE_NOBUNDLE_INSTALL_PREFIX}
       BUILD_COMMAND make -j${pcnt}
-      INSTALL_COMMAND make install
+      INSTALL_COMMAND make -j1 install
       DEPENDS ${ZLIB_TARGET}
       LOG_CONFIGURE ${EXT_BUILD_QUIET}
       LOG_BUILD ${EXT_BUILD_QUIET}

icu/CMakeLists.txt

@@ -16,7 +16,7 @@ if (NOT WIN32 AND NOT APPLE)
       BUILD_ALWAYS ${EXT_BUILD_ALWAYS} ${LOG_OPTS}
       CONFIGURE_COMMAND <SOURCE_DIR>/<SOURCE_SUBDIR>/configure --disable-extras --disable-tools --disable-tests --disable-samples --prefix=${CMAKE_BUNDLE_INSTALL_PREFIX}
       BUILD_COMMAND make -j${pcnt}
-      INSTALL_COMMAND make install
+      INSTALL_COMMAND make -j1 install
       LOG_CONFIGURE ${EXT_BUILD_QUIET}
       LOG_BUILD ${EXT_BUILD_QUIET}
       LOG_INSTALL ${EXT_BUILD_QUIET}

ncurses/CMakeLists.txt

@@ -34,7 +34,7 @@ if (NOT WIN32)
       #CONFIGURE_COMMAND ${NCURSES_SRC_DIR}/autogen.sh
       CONFIGURE_COMMAND ${NCURSES_SRC_DIR}/configure --with-shared --enable-rpath --prefix=${CMAKE_BUNDLE_INSTALL_PREFIX}
       BUILD_COMMAND make -j${pcnt}
-      INSTALL_COMMAND make install
+      INSTALL_COMMAND make -j1 install
       DEPENDS ${ZLIB_TARGET}
       LOG_CONFIGURE ${EXT_BUILD_QUIET}
       LOG_BUILD ${EXT_BUILD_QUIET}

tcl/CMakeLists.txt

@@ -71,8 +71,12 @@ if (ENABLE_TCL)
       COMMAND ${PATCH_EXECUTABLE};-E;-p1;${PATCH_OPTIONS};-i;${CMAKE_CURRENT_SOURCE_DIR}/tcl_disable_docs.patch
       COMMAND ${ZLIB_PATCH_CMD}
       CONFIGURE_COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_BINARY_DIR}/tcl_configure.cmake
-      BUILD_COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_BINARY_DIR}/tcl_build.cmake
-      INSTALL_COMMAND make install
+
+      # NOTE: Forcing -j on all sub-make calls to work around cmake+make
+      # jobserver mode bug.  Tcl also seems to have a race fixed via genstubs.
+
+      BUILD_COMMAND make -j${pcnt}
+      INSTALL_COMMAND make -j1 genstubs install
       ${RPATH_CMD}
       LOG_CONFIGURE ${EXT_BUILD_QUIET}
       LOG_BUILD ${EXT_BUILD_QUIET}
@@ -85,7 +89,10 @@ if (ENABLE_TCL)
 
   else (NOT MSVC)
 
-    # TODO - how to pass Z_PREFIX through nmake so zlib.h has the correct prefix?  Is https://stackoverflow.com/a/11041834 what we need?  Also, do we need to patch makefile.vc to reference our zlib dll?
+    # TODO - how to pass Z_PREFIX through nmake so zlib.h has the correct
+    # prefix?  Is https://stackoverflow.com/a/11041834 what we need?  Also, do
+    # we need to patch makefile.vc to reference our zlib dll?
+
     ExternalProject_Add(TCL_BLD
       URL "${CMAKE_CURRENT_SOURCE_DIR}/tcl"
       BUILD_ALWAYS ${EXT_BUILD_ALWAYS} ${LOG_OPTS}

tcl/tcl_build.cmake.in

@@ -1,23 +1,13 @@
-if (WIN32)
-  execute_process(
-    COMMAND "@VCVARS_BAT@"
-    )
-  execute_process(
-    COMMAND nmake -f makefile.vc INSTALLDIR=@CMAKE_BUNDLE_INSTALL_PREFIX@ SUFX=
-    RESULT_VARIABLE TCL_RET
-    WORKING_DIRECTORY "@TCL_SRC_DIR@/win"
-    OUTPUT_VARIABLE MSG
-    ERROR_VARIABLE MSG
-    )
-else (WIN32)
-  execute_process(
-    COMMAND make
-    RESULT_VARIABLE TCL_RET
-    WORKING_DIRECTORY "@TCL_BIN_DIR@"
-    OUTPUT_VARIABLE MSG
-    ERROR_VARIABLE MSG
-    )
-endif (WIN32)
+execute_process(
+  COMMAND "@VCVARS_BAT@"
+  )
+execute_process(
+  COMMAND nmake -f makefile.vc INSTALLDIR=@CMAKE_BUNDLE_INSTALL_PREFIX@ SUFX=
+  RESULT_VARIABLE TCL_RET
+  WORKING_DIRECTORY "@TCL_SRC_DIR@/win"
+  OUTPUT_VARIABLE MSG
+  ERROR_VARIABLE MSG
+  )
 
 if (TCL_RET)
   message(FATAL_ERROR "Tcl build failed: ${MSG}\n")

tk/CMakeLists.txt

@@ -49,7 +49,7 @@ if (TK_DO_BUILD)
       COMMAND ${PATCH_EXECUTABLE};-E;-p1;${PATCH_OPTIONS};-i;${CMAKE_CURRENT_SOURCE_DIR}/tk_disable_docs.patch
       CONFIGURE_COMMAND LD_LIBRARY_PATH=${CMAKE_BUNDLE_INSTALL_PREFIX}/${LIB_DIR} CPPFLAGS=-I${CMAKE_BUNDLE_INSTALL_PREFIX}/${INCLUDE_DIR} LDFLAGS=-L${CMAKE_BUNDLE_INSTALL_PREFIX}/${LIB_DIR} TK_SHLIB_LD_EXTRAS=-L${CMAKE_BUNDLE_INSTALL_PREFIX}/${LIB_DIR} ${TK_SRC_DIR}/unix/configure --prefix=${CMAKE_BUNDLE_INSTALL_PREFIX} --with-tcl=$<IF:$<BOOL:${TCL_TARGET}>,${CMAKE_BUNDLE_INSTALL_PREFIX}/${LIB_DIR},${TCLCONF_DIR}>
       BUILD_COMMAND make -j${pcnt}
-      INSTALL_COMMAND make install
+      INSTALL_COMMAND make -j1 install
       # Note - LOG_CONFIGURE doesn't seem to be compatible with complex CONFIGURE_COMMAND setups
       LOG_BUILD ${EXT_BUILD_QUIET}
       LOG_INSTALL ${EXT_BUILD_QUIET}