Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A redundant clsx dependecy #52

Open
VladimirCreator opened this issue Jan 18, 2024 · 0 comments · May be fixed by #78
Open

A redundant clsx dependecy #52

VladimirCreator opened this issue Jan 18, 2024 · 0 comments · May be fixed by #78

Comments

@VladimirCreator
Copy link

A redundant clsx dependecy

class-variance-authority actually already provides the functionality that clsx does and it is called cx.

cx is just an alias for clsx so I suggest removing clsx from package.json.

/src/lib.utils.ts

import { clsx } from 'clsx'
import type { ClassValue } from 'clsx'

is the same as

import { cx } from 'class-variance-authority'
import type { ClassValue } from 'class-variance-authority/types'
vibhaw1904 added a commit to vibhaw1904/cv that referenced this issue Apr 12, 2024
@vibhaw1904
[remove]:clsx BartoszJarocki#52
c3be394
@vibhaw1904 vibhaw1904 mentioned this issue Apr 12, 2024
Closed
vibhaw1904 added a commit to vibhaw1904/cv that referenced this issue May 26, 2024
@vibhaw1904
[fixes]:BartoszJarocki#52
574ea3c
@vibhaw1904 vibhaw1904 linked a pull request May 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fixes]: #52 vibhaw1904/cv
Remove clsx Fixes #52 vibhaw1904/cv
1 participant
@VladimirCreator