Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkedin for omi web personas #1752

Open
1 task
kodjima33 opened this issue Feb 3, 2025 · 12 comments · May be fixed by #1780
Open
1 task

Add linkedin for omi web personas #1752

kodjima33 opened this issue Feb 3, 2025 · 12 comments · May be fixed by #1780

Comments

@kodjima33
Copy link
Collaborator

currently, omi.me/personas only have twitter scraping

  • you need to add linkedin also
@Ana2k
Copy link

Ana2k commented Feb 4, 2025

Hi @kodjima33
Currently diving into the code base
Willing to give this a good shot.

Whats the file location for the functionality - the twitter scraping in this repo?

Thanks

@bala-ceg
Copy link

bala-ceg commented Feb 4, 2025

Hi @kodjima33
Can I try this feature? and the deliverable is web app right?
Please confirm

@harshithsunku
Copy link

Hi @kodjima33,

I have implemented the LinkedIn requirement "Add LinkedIn for OMI Web Personas #1752".

The initial draft looks good and is working fine. It successfully scrapes data from LinkedIn and creates a bot.

I have a few queries before making further changes and raising the final PR.
Whom should I reach out to for clarification?

Thanks!

Image

Image

@kodjima33
Copy link
Collaborator Author

@harshithsunku i want to test this asap - can you submit a PR? It should scrape posts as well

if it does it, I'll lock it on you

@harshithsunku
Copy link

Hi @kodjima33,

Yes, it is scraping posts as well and working fine.

I have also addressed the suggestion you provided in yesterday's weekly sync call.
Now, the button to select LinkedIn or Twitter has been removed—providing a handle will automatically determine the correct platform.

I'm a bit tied up with other tasks today,

I'll raise PR within a day or so.

Thanks.

@harshithsunku harshithsunku linked a pull request Feb 9, 2025 that will close this issue
@harshithsunku
Copy link

Hi @kodjima33 ,

Raised PR : #1780

Thanks.

@harshithsunku
Copy link

Hi @kodjima33 ,

I've raised a PR. Kindly check and lock it.
#1780

Thanks.

@andrewgazelka
Copy link

@addbounty $2000

@addbounty
Copy link

addbounty commented Feb 11, 2025

banner
button

Make a Draft PR early so others can see you are working on it! To automatically create one:

# Using npx (installed if you have NodeJS/npm)
npx bountybot start BasedHardware/omi#1752

# Or, use cargo (installed if you have Rust)
cargo install bounty
bounty start BasedHardware/omi#1752

When merged, you will receive the bounty!

@harshithsunku
Copy link

@harshithsunku i want to test this asap - can you submit a PR? It should scrape posts as well

if it does it, I'll lock it on you

Hi @kodjima33 ,

Did you get a chance to test or verify this feature/PR?

PR link: #1780

Thanks!

@kodjima33
Copy link
Collaborator Author

kodjima33 commented Feb 15, 2025

great progress bro, let's try to finish it in next 2 days and send you $!!!

here is the feedback i've sent you in DM (for reviewers to see)

@beastoin how would you rate the code 0-10?

Image

Image

@beastoin
Copy link
Collaborator

7 - lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

7 participants