Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in with Google/appple #1769

Open
kodjima33 opened this issue Feb 8, 2025 · 8 comments · May be fixed by #1781
Open

Sign in with Google/appple #1769

kodjima33 opened this issue Feb 8, 2025 · 8 comments · May be fixed by #1781

Comments

@kodjima33
Copy link
Collaborator

kodjima33 commented Feb 8, 2025

Login with Apple/google

Some people who use iPhones don't have Apple accounts to sign in. They want to
Be able to sign in with Google

@chakri-chax
Copy link

Hey there @kodjima33
I wanted to work on this issue
I have good oauth implementation knowledge.

@mdmohsin7
Copy link
Collaborator

@chakri-chax we don’t assign or lock bounties to anyone unless they have previously had a PR merged into our repository. If no one is working on an issue, feel free to drop a comment, start working on it, and open a PR.

@ibrahimnd2000
Copy link

I am working on it.

@ibrahimnd2000
Copy link

Just created a PR for this

@joshijoe05
Copy link

/attempt #1769

I have reviewed the codebase and noticed that the sign-in buttons come from different packages, resulting in inconsistencies in their appearance. To maintain a uniform look and avoid dependency on multiple packages, it would be better to create custom buttons that follow a consistent design without affecting the existing code structure

@ibrahimnd2000
Copy link

/attempt #1769

I have reviewed the codebase and noticed that the sign-in buttons come from different packages, resulting in inconsistencies in their appearance. To maintain a uniform look and avoid dependency on multiple packages, it would be better to create custom buttons that follow a consistent design without affecting the existing code structure

I addressed this here, it now uses single dependency (sign_in_button) for both of the buttons.

@joshijoe05 joshijoe05 linked a pull request Feb 10, 2025 that will close this issue
@andrewgazelka
Copy link

@addbounty $100

@addbounty
Copy link

addbounty commented Feb 11, 2025

banner
button

Make a Draft PR early so others can see you are working on it! To automatically create one:

# Using npx (installed if you have NodeJS/npm)
npx bountybot start BasedHardware/omi#1769

# Or, use cargo (installed if you have Rust)
cargo install bounty
bounty start BasedHardware/omi#1769

When merged, you will receive the bounty!

ibrahimnd2000 added a commit to ibrahimnd2000/omi that referenced this issue Feb 11, 2025
joshijoe05 added a commit to joshijoe05/omi that referenced this issue Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

7 participants