Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony Unpatch and repatching causes transpiler IL errors #81

Open
YakovAU opened this issue Aug 31, 2023 · 1 comment
Open

Harmony Unpatch and repatching causes transpiler IL errors #81

YakovAU opened this issue Aug 31, 2023 · 1 comment

Comments

@YakovAU
Copy link

YakovAU commented Aug 31, 2023

Not sure if this use case can be fixed or not, but with a hot loader, it has no issue with prefix or postfix reloading, but if you reload a transpiler it will have unknown location IL errors.

@ManlyMarco
Copy link
Member

ManlyMarco commented Aug 31, 2023

Are you sure it's not caused by other transpliers running before or something similar? I'm fairly sure I've reloaded transpliers in the past with no ill effects. See if you can isolate the issue and provide a way to reproduce it.
Always avoid using index offsets in transpliers and instead use CodeMatcher with ThrowIf statement scattered in between to ensure the method is what you think it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants