Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #4

Open
3 of 4 tasks
Berkmann18 opened this issue Aug 6, 2018 · 5 comments
Open
3 of 4 tasks

Accessibility #4

Berkmann18 opened this issue Aug 6, 2018 · 5 comments

Comments

@Berkmann18
Copy link
Owner

Berkmann18 commented Aug 6, 2018

  • W3C HTML valid?
  • W3C CSS valid?
  • Accessible (aria labels when needed)?
  • Good for colour-blindness?
@Berkmann18
Copy link
Owner Author

Berkmann18 commented Aug 8, 2018

W3C HTML result: "Document checking completed. No errors or warnings to show."
W3C CSS result: in main.css:

254 .skill-range space-evenly is not a justify-content value : space-evenly
529 .boxes space-evenly is not a justify-content value : space-evenly

@Berkmann18
Copy link
Owner Author

Berkmann18 commented Aug 8, 2018

Colour blindness results (based on the type):

  • Protanopia test outcome:

    • The secondary colour (blue) isn't really pronounced (like a broken purple close to white).
    • The skill bars are still differentiable.
    • The rest is fine.
  • Deutanopia test outcome:

    • Some of the skill bars that are grey could be hard to see (e.g: XML, MIPS).
  • Tritanopia test outcome:

    • Bootstrap's purple bar is hard to see, gimp is nearly like that too, same goes for XML and MIPS
  • Greyscale/Achromatopsia test outcome:

    • Text in secondary colour not easy to read
    • gimp's bar can't be seen

Note: the bolt icon (for "Hashnode") on index.html and the database, as well as the code icon on about.html, don't show up (other than a white stroked rectangle.

Berkmann18 added a commit that referenced this issue Aug 8, 2018
- The UI is more fluid for XL+ screens
- Accessibility measures and test were implemented (with #4 in mind)
- Removed useless code/comments
Berkmann18 added a commit that referenced this issue Aug 14, 2018
With more general accessibility for #4.
@Berkmann18
Copy link
Owner Author

/remind me in 16 days.

@reminders reminders bot added the reminder label Dec 14, 2018
@reminders
Copy link

reminders bot commented Dec 14, 2018

@Berkmann18 set a reminder for Dec 30th 2018

@reminders reminders bot removed the reminder label Dec 31, 2018
@reminders
Copy link

reminders bot commented Dec 31, 2018

👋 @Berkmann18, .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant