Fix: Problem with langfuse_tags when using litellm proxy with langfus… #7825
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
requested changes
Jan 17, 2025
| @@ -457,7 +458,7 @@ def _log_langfuse_v2( # noqa: PLR0915 | |||
| supports_costs = langfuse_version >= Version("2.7.3") | |||
| supports_completion_start_time = langfuse_version >= Version("2.7.3") | |||
|
|
|||
| tags = metadata.pop("tags", []) if supports_tags else [] | |||
| tags = json.loads(metadata.pop("tags", "[]")) if supports_tags else [] | |||
There was a problem hiding this comment.
please make this a helper function - call it _get_langfuse_tags
There was a problem hiding this comment.
I have split the method as per your suggestion. What do you think?
ishaan-jaff
requested changes
Jan 18, 2025
| @staticmethod | ||
| def _get_langfuse_tags(metadata: dict) -> list[str]: | ||
| return json.loads(metadata.pop("tags", "[]")) | ||
|
|
There was a problem hiding this comment.
can you try / except this, (don't raise an exception if there is an error)
you can do `verbose_logger.exception("error getting langfuse tags %s", str(e))
There was a problem hiding this comment.
concern here is json decode / encode errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix: Problem with langfuse_tags when using litellm proxy with langfuse integration
Relevant issues
Fixes #7801
Type
🐛 Bug Fix
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes