Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro-optimise the hell out of this package. #12

Open
TransGirlCodes opened this issue Jan 22, 2022 · 0 comments · May be fixed by #35
Open

Micro-optimise the hell out of this package. #12

TransGirlCodes opened this issue Jan 22, 2022 · 0 comments · May be fixed by #35

Comments

@TransGirlCodes
Copy link
Member

So this is just a living issue now more to say, we've got a pretty nice BioSequences package with stuff well optimised. And given the number of kmers a program will process for even a modestly sized genome, we should aim to micro-optimise the hell out of this package too, and experiment with different kmer sizes and types and explore the performance profiles.

As an example, I think for low K (and consequently low N where N is the number of UInt64's backing the kmer), implementing the canonical method one way (the way it's currently implemented in Kmers.jl), is more optimal than the more generic BioSequences version, but at higher K & N, it is not, the generic BioSequences version seems more preferrable.

Pluto notebook benchmarking canonical: https://gist.github.com/SabrinaJaye/4e3d3fbe5d90ec275e3c591bff89dec8

@jakobnissen jakobnissen linked a pull request Dec 30, 2023 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant