Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 14.4 Header Styling problem after Payment #46

Open
iabadie-dataart opened this issue Jul 15, 2021 · 9 comments
Open

iOS 14.4 Header Styling problem after Payment #46

iabadie-dataart opened this issue Jul 15, 2021 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@iabadie-dataart
Copy link

iabadie-dataart commented Jul 15, 2021

Describe the bug
After complete a payment and going back to the app, header appear with a weird bar on top (overlapping I think)
Problems seems like is with iPhone 14

To Reproduce
Steps to reproduce the behavior:

  1. Check your App header/statusbar styling
  2. Enter on MP flow.
  3. Complete a payment
  4. Go Back to the app with the cross or continue button.
  5. Check your App header/statusbar styling should be wrong

Expected behavior
App header or statusbar styling should no change after complete a MP flow.

Screenshots
ios

Smartphone (please complete the following information):
iPhone 12 - 14.4 -> Wrong styling
iPhone 8 Plus - 14.4 -> Wrong styling
iPhone 8 Plus - 13.6 -> Correct styling

Additional context
Project example to test

https://github.com/iabadie-dataart/awesomeproj-mp

Dependencies
"@blackbox-vision/react-native-mercadopago-px": "^0.7.2",
"@react-native-community/masked-view": "^0.1.11",
"@react-navigation/native": "^5.9.4",
"@react-navigation/stack": "^5.14.5",
"react": "17.0.1",
"react-native": "0.64.2",
"react-native-config": "^1.4.2",
"react-native-gesture-handler": "^1.10.3",
"react-native-reanimated": "^2.2.0",
"react-native-safe-area-context": "^3.2.0",
"react-native-screens": "^3.4.0"

@iabadie-dataart
Copy link
Author

@JonatanSalas Sorry for the Tag. Any suggestion about?

@JonatanSalas
Copy link
Member

JonatanSalas commented Jul 19, 2021

Hi @iabadie-dataart! Sorry, but I've been out from this project the last week. I'll check it out, I think that the issue is related to the UINavigationController not being able to add the previous styles. We store the information of the previous styling before MP put its own, and then we re-apply them.

Thanks for the whole information and the reproduction case, I'll use it to test the behavior and find the possible fix for this issue.

@JonatanSalas JonatanSalas self-assigned this Jul 19, 2021
@JonatanSalas JonatanSalas added the bug Something isn't working label Jul 19, 2021
@iabadie-dataart
Copy link
Author

Nice! Thanks a Lot!

@iabadie-dataart
Copy link
Author

Hi @JonatanSalas Sorry for the tag. Have you any update about this issue?
Inspecting on the Debug Hierarchy I found that when I back from a Payment as I said in the description, a new element appear on the top of the app.

I hope this help you.
I tried to solve from cliente side but I couldn't or I don't now how 😆

Before enter MP flow
image

After enter MP Flow (added element is highlighted)
image

@iabadie-dataart
Copy link
Author

@JonatanSalas Hi! Have you any update about this issue? I need to know if at least there is a way to fix from the client side maybe.

@iabadie-dataart
Copy link
Author

@JonatanSalas Hi! Any update here?

@jrocha-dataart
Copy link

Same issue here, in another project. Is there any update?

@bfacumat
Copy link

Same issue here, any update?

1 similar comment
@homerohm
Copy link

homerohm commented Dec 2, 2022

Same issue here, any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants