Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to delete hydrogen from the Styles #559

Open
julioarvellos opened this issue Jul 25, 2024 · 3 comments
Open

Add an option to delete hydrogen from the Styles #559

julioarvellos opened this issue Jul 25, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@julioarvellos
Copy link

Hello!
I want to suggest a simple feature that allows us to hide/ignore hydrogen atoms in some representations (styles) instead of removing them when importing.
Basically the idea is to add a switch node inside the node groups so we can decide if we want the hydrogens to be shown.

This is also helpful if you need to show the hydrogens in different parts of the molecule/protein with different representations.

An example of implementation:
sphere_style

Spheres node group with the checkbox + other nodes that can have this feature
delete-hydrogen

@BradyAJohnston
Copy link
Owner

I would agree it is a fairly common thing to select for when visualising, but I am unsure about including this in the interface on the node groups. We could maybe include in one of the panels, but it doesn't quite fit in any of them.

@BradyAJohnston BradyAJohnston added the enhancement New feature or request label Jul 25, 2024
@julioarvellos
Copy link
Author

julioarvellos commented Jul 26, 2024

Hmm maybe an alternative would be a node group that comes native with the structure like the Set Color and Style?
The node group could be ignored if the "Remove Hydrogen" checkbox is active when importing new structures.

Screenshot_1

Screenshot_2

@BradyAJohnston
Copy link
Owner

I've revisited this and I think having the 'hydrogens' as a toggle for the styles where it is relevant (sphere, ball & stick, surface) is probably a good idea and I'll add it in the upcoming version. Having a node which drops hydrogens is probably a bit overkill when we already have selections etc

@BradyAJohnston BradyAJohnston added this to the 4.3 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants