-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-332: React Gen 1 - Custom Components #3753
base: main
Are you sure you want to change the base?
Conversation
|
<> | ||
<BuilderBlocks | ||
parentElementId={props.builderBlock.id} | ||
dataPath={`column1.blocks`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataPath={`column1.blocks`} | |
dataPath="column1.blocks" |
/> | ||
<BuilderBlocks | ||
parentElementId={props.builderBlock.id} | ||
dataPath={`column2.blocks`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataPath={`column2.blocks`} | |
dataPath="column2.blocks" |
page, | ||
packageName, | ||
}) => { | ||
test.skip(!['gen1-react'].includes(packageName)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we adding a separate test only for gen1? why not run the existing one in this file?
page, | ||
packageName, | ||
}) => { | ||
test.skip(!['gen1-react'].includes(packageName)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question here on the new test instead of enabling the old ones
type CustomHeroProps = { | ||
children: React.ReactNode; | ||
}; | ||
|
||
const CustomHero = (props: CustomHeroProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type CustomHeroProps = { | |
children: React.ReactNode; | |
}; | |
const CustomHero = (props: CustomHeroProps) => { | |
import { type PropsWithChildren } from 'react'; | |
const CustomHero = (props: PropsWithChildren) => { |
Description
This PR adds react none gen1 code to the snippets repo and helps us add them to the docs.
@samijaber Please review.
JIRA:
https://builder-io.atlassian.net/browse/EDU-332
https://builder-io.atlassian.net/browse/EDU-331