Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-332: React Gen 1 - Custom Components #3753

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

uttej-vsk
Copy link
Contributor

Description

This PR adds react none gen1 code to the snippets repo and helps us add them to the docs.

@samijaber Please review.

JIRA:
https://builder-io.atlassian.net/browse/EDU-332
https://builder-io.atlassian.net/browse/EDU-331

@uttej-vsk uttej-vsk requested review from mrkoreye and removed request for a team November 20, 2024 16:19
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: c8158e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

<>
<BuilderBlocks
parentElementId={props.builderBlock.id}
dataPath={`column1.blocks`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dataPath={`column1.blocks`}
dataPath="column1.blocks"

/>
<BuilderBlocks
parentElementId={props.builderBlock.id}
dataPath={`column2.blocks`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dataPath={`column2.blocks`}
dataPath="column2.blocks"

page,
packageName,
}) => {
test.skip(!['gen1-react'].includes(packageName));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we adding a separate test only for gen1? why not run the existing one in this file?

page,
packageName,
}) => {
test.skip(!['gen1-react'].includes(packageName));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here on the new test instead of enabling the old ones

Comment on lines +1 to +5
type CustomHeroProps = {
children: React.ReactNode;
};

const CustomHero = (props: CustomHeroProps) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type CustomHeroProps = {
children: React.ReactNode;
};
const CustomHero = (props: CustomHeroProps) => {
import { type PropsWithChildren } from 'react';
const CustomHero = (props: PropsWithChildren) => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants