[phrasePlugin][Stale Private Key]: #3755
Conversation
|
| @@ -34,11 +34,12 @@ export class Phrase { | |||
| } | |||
|
|
|||
| async request(path: string, config?: RequestInit, search = {}) { | |||
| let privateKey = await appState.globalState.getPluginPrivateKey(pkg.name); | |||
There was a problem hiding this comment.
This would be expensive, since it would hit firestore everytime instead of once per load. I think that's the reason why it is cached.
Could we look at how many times this URL is called daily to understand impact?
Co-authored-by: Sanyam Kamat <[email protected]>
@sanyamkamat since Jira is our internal project and this is open source, I thought we were not adding jira ids here |
…v2023/builder into ENG-7441-phrase-private-key-issue
Description
The Private key in phrase plugin gets updated only in constructor i.e. when the plugin loads. This happens on initial set-up or when we refresh builder web-app. This stale private key causes authorization failure when we switch b/w environments.
The solution is a small fix which gets the latest private key everytime before making api-call.
Loom showing before after
https://www.loom.com/share/63c07935720749b7800aaf422b771ae4