From 834ea2d14111fe6b5eaa14a05f64ee91384487c2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ra=C3=BCl=20Bonet?=
 <64003978+raulbonet@users.noreply.github.com>
Date: Tue, 16 Apr 2024 20:17:49 +0200
Subject: [PATCH] fix: Removed unnecessary and problematic column caching
 (#2352)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* deprecate column caching

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Cody J. Hanson <cody@meltano.com>
Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com>
---
 singer_sdk/connectors/sql.py | 42 +++++++++++++++---------------------
 1 file changed, 17 insertions(+), 25 deletions(-)

diff --git a/singer_sdk/connectors/sql.py b/singer_sdk/connectors/sql.py
index 6d22d5994..132c37518 100644
--- a/singer_sdk/connectors/sql.py
+++ b/singer_sdk/connectors/sql.py
@@ -58,8 +58,6 @@ def __init__(
         """
         self._config: dict[str, t.Any] = config or {}
         self._sqlalchemy_url: str | None = sqlalchemy_url or None
-        self._table_cols_cache: dict[str, dict[str, sa.Column]] = {}
-        self._schema_cache: set[str] = set()
 
     @property
     def config(self) -> dict:
@@ -586,12 +584,8 @@ def schema_exists(self, schema_name: str) -> bool:
         Returns:
             True if the database schema exists, False if not.
         """
-        if schema_name not in self._schema_cache:
-            self._schema_cache = set(
-                sa.inspect(self._engine).get_schema_names(),
-            )
-
-        return schema_name in self._schema_cache
+        schemas = set(sa.inspect(self._engine).get_schema_names())
+        return schema_name in schemas
 
     def get_table_columns(
         self,
@@ -607,24 +601,22 @@ def get_table_columns(
         Returns:
             An ordered list of column objects.
         """
-        if full_table_name not in self._table_cols_cache:
-            _, schema_name, table_name = self.parse_full_table_name(full_table_name)
-            inspector = sa.inspect(self._engine)
-            columns = inspector.get_columns(table_name, schema_name)
-
-            self._table_cols_cache[full_table_name] = {
-                col_meta["name"]: sa.Column(
-                    col_meta["name"],
-                    col_meta["type"],
-                    nullable=col_meta.get("nullable", False),
-                )
-                for col_meta in columns
-                if not column_names
-                or col_meta["name"].casefold()
-                in {col.casefold() for col in column_names}
-            }
+        _, schema_name, table_name = self.parse_full_table_name(full_table_name)
+        inspector = sa.inspect(self._engine)
+        columns = inspector.get_columns(table_name, schema_name)
+
+        columns_dict: dict[str, sa.Column] = {
+            col_meta["name"]: sa.Column(
+                col_meta["name"],
+                col_meta["type"],
+                nullable=col_meta.get("nullable", False),
+            )
+            for col_meta in columns
+            if not column_names
+            or col_meta["name"].casefold() in {col.casefold() for col in column_names}
+        }
 
-        return self._table_cols_cache[full_table_name]
+        return columns_dict
 
     def get_table(
         self,