Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mount with read-only in rclone #902

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

prateekmedia
Copy link
Member

@prateekmedia prateekmedia commented Aug 31, 2024

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

Currently rclone mounts with full permission on windows. this PR restricts it to read-only.

@prateekmedia prateekmedia changed the title fix(windows): mount with read-only in rclone [FIX] mount with read-only in rclone Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (3dc0751) to head (58a6950).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          35       35           
  Lines        3695     3695           
  Branches      747      747           
=======================================
  Hits         3211     3211           
  Misses        348      348           
  Partials      136      136           
Flag Coverage Δ
unittests 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canihavesomecoffee canihavesomecoffee merged commit b99bbd4 into CCExtractor:master Aug 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants