Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latent parameters in reverse order #440

Open
SamuelBrand1 opened this issue Aug 28, 2024 · 3 comments · May be fixed by #441
Open

Latent parameters in reverse order #440

SamuelBrand1 opened this issue Aug 28, 2024 · 3 comments · May be fixed by #441
Labels
bug Something isn't working EpiAware

Comments

@SamuelBrand1
Copy link
Collaborator

We have a usual dot-product-on-recent state pattern for AR here. However, in the constructor it seems more natural to define the damp_priors $\psi_1 \sim \pi_1,\dots,\psi_p \sim \pi_p$ in the usual order, rather than reverse order (that how it is in the replication note).

I think just putting reverse into the ARStep constructor is the best way here. Noting that Renewal should follow this convention too for style unity across EpiAware. This can be address by addressing #384 (Renewal is only place that uses scan now.)

@SamuelBrand1 SamuelBrand1 added bug Something isn't working EpiAware labels Aug 28, 2024
@seabbs
Copy link
Collaborator

seabbs commented Aug 28, 2024

Agree

@SamuelBrand1 SamuelBrand1 linked a pull request Aug 28, 2024 that will close this issue
@SamuelBrand1 SamuelBrand1 linked a pull request Aug 28, 2024 that will close this issue
@SamuelBrand1
Copy link
Collaborator Author

This is still blocked as going to be superseded by a new ARMA/ARIMA approach.

@seabbs
Copy link
Collaborator

seabbs commented Dec 12, 2024

Widen the scope of this issue to all latent models to make sure their parameters are in the order we expect.

#438 (comment)

@seabbs seabbs changed the title AR parameters in reverse order Latent parameters in reverse order Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EpiAware
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants