Fix memory leak

Author: sebastiangrimberg

interface/ceed-basis.c

@@ -845,8 +845,7 @@ int CeedBasisCreateHdiv(Ceed ceed, CeedElemTopology topo, CeedInt num_comp, Ceed
   @param[in]  num_nodes Total number of nodes (dofs per element)
   @param[in]  num_qpts  Total number of quadrature points
   @param[in]  interp    Row-major (dim * num_qpts * num_nodes) matrix expressing the values of basis functions at quadrature points
-  @param[in]  curl      Row-major (cdim * num_qpts * num_nodes, cdim = 1 if dim < 3 else dim) matrix expressing curl of basis functions at quadrature
-points
+  @param[in]  curl      Row-major (cdim * num_qpts * num_nodes, cdim = 1 if dim < 3 else dim) matrix expressing curl of basis functions at quadrature points
   @param[in]  q_ref     Array of length num_qpts * dim holding the locations of quadrature points on the reference element
   @param[in]  q_weight  Array of length num_qpts holding the quadrature weights on the reference element
   @param[out] basis     Address of the variable where the newly created CeedBasis will be stored.
@@ -1095,7 +1094,7 @@ int CeedBasisApply(CeedBasis basis, CeedInt num_elem, CeedTransposeMode t_mode,
       break;
     case CEED_EVAL_NONE:
     case CEED_EVAL_INTERP:
-      qdim     = (fe_space == CEED_FE_SPACE_H1) ? 1 : dim;
+      qdim = (fe_space == CEED_FE_SPACE_H1) ? 1 : dim;
       bad_dims = ((t_mode == CEED_TRANSPOSE && (u_length < num_elem * num_comp * num_qpts * qdim || v_length < num_elem * num_comp * num_nodes)) ||
                   (t_mode == CEED_NOTRANSPOSE && (v_length < num_elem * num_qpts * num_comp * qdim || u_length < num_elem * num_comp * num_nodes)));
       break;
@@ -1108,7 +1107,7 @@ int CeedBasisApply(CeedBasis basis, CeedInt num_elem, CeedTransposeMode t_mode,
                   (t_mode == CEED_NOTRANSPOSE && (v_length < num_elem * num_qpts * num_comp || u_length < num_elem * num_comp * num_nodes)));
       break;
     case CEED_EVAL_CURL:
-      cdim     = (dim < 3) ? 1 : dim;
+      cdim = (dim < 3) ? 1 : dim;
       bad_dims = ((t_mode == CEED_TRANSPOSE && (u_length < num_elem * num_comp * num_qpts * cdim || v_length < num_elem * num_comp * num_nodes)) ||
                   (t_mode == CEED_NOTRANSPOSE && (v_length < num_elem * num_qpts * num_comp * cdim || u_length < num_elem * num_comp * num_nodes)));
       break;
@@ -1451,13 +1450,14 @@ int CeedBasisDestroy(CeedBasis *basis) {
   if (!*basis || --(*basis)->ref_count > 0) return CEED_ERROR_SUCCESS;
   if ((*basis)->Destroy) CeedCall((*basis)->Destroy(*basis));
   if ((*basis)->contract) CeedCall(CeedTensorContractDestroy(&(*basis)->contract));
+  CeedCall(CeedFree(&(*basis)->q_ref_1d));
+  CeedCall(CeedFree(&(*basis)->q_weight_1d));
   CeedCall(CeedFree(&(*basis)->interp));
   CeedCall(CeedFree(&(*basis)->interp_1d));
   CeedCall(CeedFree(&(*basis)->grad));
-  CeedCall(CeedFree(&(*basis)->div));
   CeedCall(CeedFree(&(*basis)->grad_1d));
-  CeedCall(CeedFree(&(*basis)->q_ref_1d));
-  CeedCall(CeedFree(&(*basis)->q_weight_1d));
+  CeedCall(CeedFree(&(*basis)->div));
+  CeedCall(CeedFree(&(*basis)->curl));
   CeedCall(CeedDestroy(&(*basis)->ceed));
   CeedCall(CeedFree(basis));
   return CEED_ERROR_SUCCESS;
@@ -1872,27 +1872,26 @@ CeedPragmaOptimizeOn
 }
 CeedPragmaOptimizeOn
 
-    /**
-      @brief Apply Householder Q matrix
+/**
+  @brief Apply Householder Q matrix
 
-        Compute A = Q A, where Q is mxm and A is mxn.
+    Compute A = Q A, where Q is mxm and A is mxn.
 
-      @param[in,out] A      Matrix to apply Householder Q to, in place
-      @param[in]     Q      Householder Q matrix
-      @param[in]     tau    Householder scaling factors
-      @param[in]     t_mode Transpose mode for application
-      @param[in]     m      Number of rows in A
-      @param[in]     n      Number of columns in A
-      @param[in]     k      Number of elementary reflectors in Q, k<m
-      @param[in]     row    Row stride in A
-      @param[in]     col    Col stride in A
+  @param[in,out] A      Matrix to apply Householder Q to, in place
+  @param[in]     Q      Householder Q matrix
+  @param[in]     tau    Householder scaling factors
+  @param[in]     t_mode Transpose mode for application
+  @param[in]     m      Number of rows in A
+  @param[in]     n      Number of columns in A
+  @param[in]     k      Number of elementary reflectors in Q, k<m
+  @param[in]     row    Row stride in A
+  @param[in]     col    Col stride in A
 
-      @return An error code: 0 - success, otherwise - failure
+  @return An error code: 0 - success, otherwise - failure
 
-      @ref Developer
-    **/
-    int
-    CeedHouseholderApplyQ(CeedScalar *A, const CeedScalar *Q, const CeedScalar *tau, CeedTransposeMode t_mode, CeedInt m, CeedInt n, CeedInt k,
+  @ref Developer
+**/
+int CeedHouseholderApplyQ(CeedScalar *A, const CeedScalar *Q, const CeedScalar *tau, CeedTransposeMode t_mode, CeedInt m, CeedInt n, CeedInt k,
                           CeedInt row, CeedInt col) {
   CeedScalar *v;
   CeedCall(CeedMalloc(m, &v));
@@ -1933,4 +1932,4 @@ int CeedMatrixMatrixMultiply(Ceed ceed, const CeedScalar *mat_A, const CeedScala
   return CEED_ERROR_SUCCESS;
 }
 
-/// @}
+    /// @}