Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to properly add a time delta per-player #23

Open
brandonsturgeon opened this issue Aug 31, 2020 · 0 comments
Open

Figure out how to properly add a time delta per-player #23

brandonsturgeon opened this issue Aug 31, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@brandonsturgeon
Copy link
Member

Right now if a player joins 1 second before the batch update, they'll get an extra updateInterval - 1 seconds.

We could set their duration to now - joined but I like the idea of it always being additive instead of definitive.

Once we fix this, we can also fix the issue where if the timer stops then starts, some players would get way more time than they earned (if they joined well after the timer stopped) because the timer will always add now - lastUpdate seconds to every player.

@brandonsturgeon brandonsturgeon added the bug Something isn't working label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant