Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed: Logic to make basemaps not control timeline when paired with other layer #183

Closed
jjkohler opened this issue Nov 19, 2020 · 7 comments
Assignees
Labels
Critical for Release Refactor Refactor Branch Specific

Comments

@jjkohler
Copy link
Collaborator

jjkohler commented Nov 19, 2020

See examples below

@rsargent
Copy link
Member

rsargent commented Dec 2, 2020

Normally, the last selected layer (rightmost in the share link) controls the timeline. But layers without timelines don't affect this.

Proposed behavior #3: Layers with single timestamp (begin time = end time) show a year without a timeline. And enforce that animated base layers like landsat pause that at same time.

Proposed behavior #1: Base map timeline always has lower priority than other layer's timeline, even if the base map is later in the share link.

#2: If overlay layer has a single time (begin time = end time) e.g. Cropland Extents 2015, display that year by the timeline but without an actual timeline bar+scrubber. This should override basemap timeline too like #1, and would seek the basemap to the closest time representable (e.g. layer is 2000 shows landsat 2000, or layer is 1950 shows landsat 1984).

#3. For Forest loss by year 2000-2018 atop landsat, show landsat 2018 and no year at the bottom.

@rsargent rsargent assigned gabrielo and unassigned pdille Dec 9, 2020
@gabrielo
Copy link
Member

gabrielo commented Dec 9, 2020

Testing URLs
1 Base map timeline always has lower priority than other layer's timeline, even if the base map is later in the share link.
https://staging.earthtime.org/explore#v=4.56342,0,0,latLng&t=2.66&ps=50&l=pure_earth_modern_pollution,bdrk&bt=19900101&et=20161231&startDwell=0&endDwell=0

2 Layers with single timestamp (begin time = end time) show a year without a timeline. And enforce that animated base layers like landsat pause that at same time.
https://staging.earthtime.org/explore#v=54.9517,-4.52115,4.594,latLng&t=3.57&ps=50&l=uk_eu_referendum_2016,blsat&bt=19840101&et=20191231&startDwell=0&endDwell=0

@gabrielo
Copy link
Member

Logic added with commit 145bf07

Displaying single year and or span of years requires further development.

@gabrielo
Copy link
Member

If data visualization layer has a single time (begin time = end time) e.g. Cropland Extents 2015, display that year by the timeline but without an actual timeline bar+scrubber.
#194

@jjkohler
Copy link
Collaborator Author

jjkohler commented Feb 5, 2021

I believe that all the documented cases related to this issue have now been solved. Pending any further issues being identified, this issue can be closed.

@jjkohler jjkohler closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical for Release Refactor Refactor Branch Specific
Projects
None yet
Development

No branches or pull requests

4 participants